Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

notification popup improvements - link to file #enhancement #18

Closed
jroachgit opened this issue Sep 7, 2021 · 3 comments
Closed

notification popup improvements - link to file #enhancement #18

jroachgit opened this issue Sep 7, 2021 · 3 comments
Labels
enhancement New feature or request reviewing

Comments

@jroachgit
Copy link

Hi,
Great work on this plugin.
Are you able to add a link on the notification popup to take you to the file?

@jroachgit jroachgit changed the title notification popup improvements - link to file notification popup improvements - link to file #enhancement Sep 7, 2021
@uphy uphy added the enhancement New feature or request label Sep 7, 2021
@uphy
Copy link
Owner

uphy commented Sep 8, 2021

That's a feature I wanted too.

But currently reminder notification is implemented as a modal.
So when you click the link in the modal, the modal will be closed or hard to see the link destination page.
I am wondering what UI to use for reminder.

@uphy
Copy link
Owner

uphy commented Sep 14, 2021

@jroachgit Added link to file in reminder modal in v1.1.0.
Please try to click file path in reminder modal.

When you click the file path, the file will be appeared and the modal is closed.
The reminder is muted once and moved to Overdue section in reminder list view.

@uphy uphy added the reviewing label Sep 14, 2021
@uphy
Copy link
Owner

uphy commented Nov 3, 2021

Since there is no response, I'm closing this once.
Please reopen if there is anything.

@uphy uphy closed this as completed Nov 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request reviewing
Projects
None yet
Development

No branches or pull requests

2 participants