Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] parameter to add extra URDFs #81

Merged
merged 16 commits into from
Jan 31, 2024

Conversation

ubgk
Copy link
Contributor

@ubgk ubgk commented Jan 31, 2024

This PR introduces a new parameter (i.e. a vector of strings) that can be used to specify additional URDFs to be loaded into simulation at launch time.

Closes #80.

@coveralls
Copy link

coveralls commented Jan 31, 2024

Pull Request Test Coverage Report for Build 7726630738

  • -4 of 5 (20.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.2%) to 89.431%

Changes Missing Coverage Covered Lines Changed/Added Lines %
vulp/actuation/BulletInterface.cpp 1 5 20.0%
Totals Coverage Status
Change from base Build 7608961794: -0.2%
Covered Lines: 1760
Relevant Lines: 1968

💛 - Coveralls

@stephane-caron
Copy link
Member

LGTM 👍

If you feel so inclined you can also blast loading a ground plane URDF (removing the dependency on bazel::tools::cpp::runfiles::Runfiles) and pass the ground as an extra URDF in the Upkie spine. This would help with @pgraverdy's work where we cannot rely on Bazel runfiles any more.

@stephane-caron stephane-caron merged commit 35fcef2 into upkie:main Jan 31, 2024
14 checks passed
@ubgk
Copy link
Contributor Author

ubgk commented Feb 1, 2024

Circling back on this, can we just not set params.floor to false and pass the known ground plane URDF in params.extra_urdf_paths?

cc @pgraverdy

@stephane-caron
Copy link
Member

Yes, and once that works, you can remove params.floor altogether 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Creating a Bullet client in a different process
3 participants