Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate PUT /group/{uuid}/storage/ #131

Closed
rsedykh opened this issue Oct 18, 2023 · 4 comments
Closed

Deprecate PUT /group/{uuid}/storage/ #131

rsedykh opened this issue Oct 18, 2023 · 4 comments
Assignees
Labels

Comments

@rsedykh
Copy link
Member

rsedykh commented Oct 18, 2023

It was deprecated.

image

https://uploadcare.com/api-refs/upload-api/#tag/Groups/operation/filesGroupInfo
https://uploadcare.com/api-refs/rest-api/v0.7.0/#tag/Group/operation/groupInfo

To store or remove files from a group, query the list of files in it, split the list into chunks of 100 files per chunk and then perform batch file storing or batch file removal for all the chunks.

p.s. Don't forget to update https://github.com/uploadcare/uploadcare-rails-example if necessary.

@vipulnsward
Copy link
Collaborator

vipulnsward commented Apr 2, 2024

To store or remove files from a group, query the list of files in it, split the list into chunks of 100 files per chunk and then perform batch file storing or batch file removal for all the chunks.

We already do this for store. For delete, we just delete the group. I will update the README to reflect this comment from https://uploadcare.com/api-refs/rest-api/v0.7.0/#tag/Group/operation/deleteGroup

p.s. Don't forget to update uploadcare-php-example if necessary.

I think this is an unrelated comment?

@rsedykh
Copy link
Member Author

rsedykh commented Apr 3, 2024

Oops. I've meant https://github.com/uploadcare/uploadcare-rails-example

vipulnsward added a commit that referenced this issue Apr 6, 2024
…using the logger if available to warn about deprecation of datetime_created property on file entity. Overrid and add datetime_stored method for the same. Clarify in README about the usage of delete operation on group that leaves the files intact.Closes #131
@vipulnsward vipulnsward reopened this Apr 6, 2024
@vipulnsward
Copy link
Collaborator

vipulnsward commented Apr 6, 2024

Added a soft deprecation warning in this version, will raise or drop allowing this value from entity in future versions

Keeping it open till then

@vipulnsward
Copy link
Collaborator

Closing this, we can't remove it completely till API removes it, will let the deprecate live and remove it in future

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants