Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signed URLs updates #134

Open
rsedykh opened this issue Nov 15, 2023 · 0 comments
Open

Signed URLs updates #134

rsedykh opened this issue Nov 15, 2023 · 0 comments
Assignees
Labels

Comments

@rsedykh
Copy link
Member

rsedykh commented Nov 15, 2023

I want uploadcare-ruby to have the same signed URL capabilities as pyuploadcare. Correct me if this is something wrong to do (or already done, or requires to build something else).


Implement generating URL tokens for signed URLs

Currently, the lib allows for generating ACL tokens only. Akamai supports two type of tokens: ACL and URL. See https://github.com/akamai/EdgeAuth-Token-Python/blob/master/akamai/edgeauth/edgeauth.py for reference.

Allow to pass a UUID + params when generating signed URL (ACL)

Currently, the AkamaiSecureUrlBuilder class allows for signing a whole URL. In some cases, there's a need to generate a universal ACL token with wildcards. For example, we can specify an ACL as follows:

/{uuid}/*

and the token generated will be applicable to any variation of the file associated with the {uuid}. E.g., https://ucarecdn.com/{uuid}/-/resize/360x/-/format/auto/

See https://github.com/akamai/EdgeAuth-Token-Python/blob/master/akamai/edgeauth/edgeauth.py#L183 for reference.


You can use pyuploadcare implementation as a reference:

@rsedykh rsedykh added the cdn label Nov 21, 2023
@vipulnsward vipulnsward self-assigned this Apr 7, 2024
vipulnsward added a commit that referenced this issue Apr 13, 2024
…Fix docs, specs and imports from all places. Start adding acl to signed signature building for UC::SignedUrlGenerators::AkamaiGenerator. Add accepting wildcard param to generate_url and then passing down to building an ACL
vipulnsward added a commit that referenced this issue Apr 20, 2024
vipulnsward added a commit that referenced this issue Apr 27, 2024
…it to generate signed url in Akamai url generator
vipulnsward added a commit that referenced this issue Apr 27, 2024
* [gh-134] Fix Amakai class name typo in signed generators, to Akamai. Fix docs, specs and imports from all places. Start adding acl to signed signature building for UC::SignedUrlGenerators::AkamaiGenerator. Add accepting wildcard param to generate_url and then passing down to building an ACL

* Add back explicit wildcard param sending

* README fixes and formatting for Uploadcare::SignedUrlGenerators::AkamaiGenerator to make it more readable and to be able to copy code easily

* [gh-134] Fix the secret key being used as a wrong format when we use it to generate signed url in Akamai url generator

* [gh-134] Fix hmacs in generated spec urls

* Fix AkamaiGenerator typos

* Rubocop fixes

* One more typo

* Document all Uploadcare::SignedUrlGenerators::AkamaiGenerator and generate_url options in README

* Add the typo fix in the README related to AmakaiGenerator fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants