Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

daf-ethr-did implement import/exportIdentity #105

Closed
rado0x54 opened this issue Mar 17, 2020 · 5 comments
Closed

daf-ethr-did implement import/exportIdentity #105

rado0x54 opened this issue Mar 17, 2020 · 5 comments
Labels
wontfix This will not be worked on

Comments

@rado0x54
Copy link
Contributor

Hey,

we would have a use-case to initialize the identity store with a reproducibly same key/identity, but currently the methods importIdentity and exportIdentity are not implemented on daf-ethr-did. Would the export Format just be a string of an encoded private Key or contain any other information?

If there is another way to initialize daf with a consistent identity, that would also help as a workaround.

Also there is a minor typo in the AbstractIdentityProvider:

  exportIdentity(did: string): Promise<string> {
    return Promise.reject('Method importIdentity not implemented')
  }
@simonas-notcat
Copy link
Contributor

@rado0x54 daf identity-manager --import and daf identity-manager --export

@rado0x54
Copy link
Contributor Author

Thanks, I'll have a look.!

@rado0x54
Copy link
Contributor Author

Hey @simonas-notcat, in my mind the importIdentity should not require the identityProviderType if that is part of the export. Furthermore, the export provider string is not the one required. So there must be some discrepancy in the code.
Export: "provider":"rinkeby-ethr"
Required: rinkeby-ethr-did
e.g. this code did not work for me because of that.

      let jsonIssuerConfig = JSON.parse(process.env.ISSUER_IDENTITY);
      await core.identityManager.importIdentity(jsonIssuerConfig.provider, process.env.ISSUER_IDENTITY);

So either don't export the provider or don't require it on import.

@rado0x54 rado0x54 reopened this Mar 20, 2020
@stale
Copy link

stale bot commented Dec 19, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Dec 19, 2020
@rado0x54
Copy link
Contributor Author

Closing issue, since it was superseded by code changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants