-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed daf-resolver configuration #298
Conversation
Codecov Report
@@ Coverage Diff @@
## beta #298 +/- ##
==========================================
- Coverage 65.96% 65.27% -0.70%
==========================================
Files 64 63 -1
Lines 1569 1552 -17
Branches 243 242 -1
==========================================
- Hits 1035 1013 -22
- Misses 438 444 +6
+ Partials 96 95 -1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great!
I think we should also add some examples or tests that show how this links to (or solves) #205
resolver: new Resolver({ | ||
ethr: ethrDidResolver({ | ||
networks: [ | ||
{ name: 'mainnet', rpcUrl: 'https://mainnet.infura.io/v3/' + infuraProjectId }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would be a good place to test that using a custom web3 provider also works.
It would be something like this: { name: 'rinkeby', provider: myCustomWeb3Provider }
- networks: | ||
- name: mainnet | ||
rpcUrl: https://mainnet.infura.io/v3/5ffc47f65c4042ce847ef66a3fa70d4c | ||
- name: rinkeby |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is also a good place to try to use a custom web3 provider class
This is a breaking change.
Add this to your
agent.yml
:Update
agent.plugins