fix: remove local network from default did:ethr config #428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## next #428 +/- ##
==========================================
- Coverage 67.58% 65.60% -1.98%
==========================================
Files 62 68 +6
Lines 1530 1608 +78
Branches 247 264 +17
==========================================
+ Hits 1034 1055 +21
- Misses 400 450 +50
- Partials 96 103 +7 |
mirceanis
added a commit
that referenced
this pull request
Mar 26, 2021
BREAKING CHANGES: * `IResolver` interface adapted to core spec * No more `EcdsaSignature` for signers, only `string` output * Signers must accept `Uint8Array` input as well as `string` * Using EcdsaSecp256k1VerificationKey2019 and ...RecoveryMethod2020 * using `verificationMethod` and `blockchainAccountId` from DID documents * deprecated `UniversalResolver` class in favor of `getUniversalResolver` method closes #418 closes #428 closes #417 closes #416 closes #412 closes #397 unblocks #384 fixes #394
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As highlighted in #426, the default config for did:ethr resolver contains an entry for a local network and registry which should not be there.