fix: speed up secp256k1 keygen #551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## next #551 +/- ##
==========================================
+ Coverage 67.58% 77.20% +9.62%
==========================================
Files 62 71 +9
Lines 1530 1869 +339
Branches 247 314 +67
==========================================
+ Hits 1034 1443 +409
- Misses 400 424 +24
+ Partials 96 2 -94 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #549
Since #529 got merged, secp256k1 key generation is very slow on react-native (tested on android).
The culprit seems to be the
pbkdf2method that gets called by@ethersproject/wallet#Wallet.createRandom()This fix instantiates a
SigningKeydirectly instead of deriving from a mnemonic, therefore sidestepping the call to pbkdf2