New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Confusing `if` condition #637

Closed

unknwon opened this issue Dec 10, 2021 · 1 comment · Fixed by #638

unknwon commented Dec 10, 2021

db/internal/sqladapter/exql/template.go

Line 84 in cb7617e

if !ok || true {

This is always true.

xiam mentioned this issue

Fix condition that forced the statement cache to be skipped #638

Merged

Member

xiam commented Dec 11, 2021

Great finding! this was probably a leftover and caused the query template cache to be skipped at this level. Fixing, thank you very much.

xiam closed this as completed in #638

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment