Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fatal error in WordPress 4.6 #5

Closed
stewarty opened this issue Aug 24, 2016 · 5 comments
Closed

Fatal error in WordPress 4.6 #5

stewarty opened this issue Aug 24, 2016 · 5 comments
Labels

Comments

@stewarty
Copy link

WordPress 4.6 now includes Ryan McCue's Requests Library.

When using Routes it is possible to get a Fatal Error as you are also including this Library but in an older version it would seem? Anyway, The Request_Response Classes aren't the same. Yours is getting used in preference to the included one. This causes the is_redirect() method to be reported as missing and WP has a fatal crash.

Fix in the meantime is to just delete the Requests Folder in vendor

@jarednova
Copy link
Member

Thanks for the heads-up on this @stewarty, sounds like I need to do some 4.6 testing! Could you point me to where in the code the conflicting classes are? Is this something in this repo, or one of the dependencies I'm using? (like AltoRouter)

@jarednova jarednova added the bug label Aug 25, 2016
@stewarty
Copy link
Author

It's in your dependencies. rmmcue/requests

Is it actually being used?

The Resquest_Response class is conflicting!

Sent from my iPhone

On 25 Aug 2016, at 14:34, Jared Novack notifications@github.com wrote:

Thanks for the heads-up on this @stewarty, sounds like I need to do some 4.6 testing! Could you point me to where in the code the conflicting classes are? Is this something in this repo, or one of the dependencies I'm using? (like AltoRouter)


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

@jarednova
Copy link
Member

Hi @stewarty, I'm sorry but I'm not able to find rmmcue/requests in the dependencies or elsewhere in the code. The dependencies I'm using are just Altorouter, Composer and PHP. Can you point to where exactly this exists? Is this the current master or a past version of this repo?

@stewarty
Copy link
Author

stewarty commented Sep 8, 2016

Gottya - its actually in wp-cli

https://github.com/wp-cli/wp-cli/blob/master/composer.json#L17

@jarednova
Copy link
Member

I will crush them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants