Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add image compression #14

Closed
wants to merge 1 commit into from
Closed

Add image compression #14

wants to merge 1 commit into from

Conversation

soulofmischief
Copy link
Contributor

Compress images for ~1.8MiB wins using https://www.npmjs.com/package/browser-image-compression

We should fork this package if we're going to use it.

@vercel
Copy link

vercel bot commented Dec 18, 2022

@soulofmischief is attempting to deploy a commit to the WEBA Team on Vercel.

To accomplish this, @soulofmischief needs to request access to the Team.

Afterwards, an owner of the Team is required to accept their membership request.

If you're already a member of the respective Vercel Team, make sure that your Personal Vercel Account is connected to your GitHub account.

@soulofmischief soulofmischief mentioned this pull request Dec 18, 2022
7 tasks
@avaer
Copy link
Contributor

avaer commented Dec 18, 2022

Could just use JPEG. Have you compared that?

@soulofmischief
Copy link
Contributor Author

Could just use JPEG. Have you compared that?

I haven't, but I figured take the easy gains now and then test quality/size of a few different image types/configurations later. Is that okay for now?

@avaer
Copy link
Contributor

avaer commented Dec 20, 2022

I think JPEG would be fine in terms of live artifacts, plus it would load faster.

If we wanted higher quality this seems like a good approach, but IMO speed is more important now.

@soulofmischief
Copy link
Contributor Author

Closed for now in favor of #16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants