Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
covr
has been broken with pkgnet for a while, since #108 was merged.This has caused our codecov to silently fail in in the Travis "after_success" build steps.
The same error was seen when trying to run
covr::package_coverage
locally (or by trying to runFunctionReporter
withcalculate_test_coverage
).This was due to the way
covr
installs the package into a temporary directory before it does all of its stuff. The directory structure in thecovr
case wasn't included in the list of directory sanitation in.BuildTestLib
.Additionally, because we had to install the test packages from an installed copy of
pkgnet
source rather than the raw source, the test packages had all been moved out of inst up into the root package directory, so the path to the test package source had to be adjusted.