Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed .BuildTestLib for covr #144

Merged
merged 1 commit into from
Dec 8, 2018
Merged

Fixed .BuildTestLib for covr #144

merged 1 commit into from
Dec 8, 2018

Conversation

jayqi
Copy link
Collaborator

@jayqi jayqi commented Dec 8, 2018

covr has been broken with pkgnet for a while, since #108 was merged.

This has caused our codecov to silently fail in in the Travis "after_success" build steps.

The same error was seen when trying to run covr::package_coverage locally (or by trying to run FunctionReporter with calculate_test_coverage).

This was due to the way covr installs the package into a temporary directory before it does all of its stuff. The directory structure in the covr case wasn't included in the list of directory sanitation in .BuildTestLib.

Additionally, because we had to install the test packages from an installed copy of pkgnet source rather than the raw source, the test packages had all been moved out of inst up into the root package directory, so the path to the test package source had to be adjusted.

@codecov-io
Copy link

codecov-io commented Dec 8, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@71c6163). Click here to learn what that means.
The diff coverage is 87.5%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #144   +/-   ##
=========================================
  Coverage          ?   86.62%           
=========================================
  Files             ?       10           
  Lines             ?      897           
  Branches          ?        0           
=========================================
  Hits              ?      777           
  Misses            ?      120           
  Partials          ?        0
Impacted Files Coverage Δ
R/testing_utils.R 77.14% <87.5%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71c6163...8f09703. Read the comment docs.

Copy link
Collaborator

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Well done.

@jameslamb jameslamb merged commit 70a3857 into uptake:master Dec 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants