Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFixed .BuildTestLib for covr #144
Conversation
Codecov Report
@@ Coverage Diff @@
## master #144 +/- ##
=========================================
Coverage ? 86.62%
=========================================
Files ? 10
Lines ? 897
Branches ? 0
=========================================
Hits ? 777
Misses ? 120
Partials ? 0
Continue to review full report at Codecov.
|
|
LGTM! Well done. |
covrhas been broken with pkgnet for a while, since #108 was merged.This has caused our codecov to silently fail in in the Travis "after_success" build steps.
The same error was seen when trying to run
covr::package_coveragelocally (or by trying to runFunctionReporterwithcalculate_test_coverage).This was due to the way
covrinstalls the package into a temporary directory before it does all of its stuff. The directory structure in thecovrcase wasn't included in the list of directory sanitation in.BuildTestLib.Additionally, because we had to install the test packages from an installed copy of
pkgnetsource rather than the raw source, the test packages had all been moved out of inst up into the root package directory, so the path to the test package source had to be adjusted.