Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_data includes a file only used for ES 7 and up #167

Open
jameslamb opened this issue Sep 4, 2019 · 0 comments
Open

test_data includes a file only used for ES 7 and up #167

jameslamb opened this issue Sep 4, 2019 · 0 comments

Comments

@jameslamb
Copy link
Collaborator

See this comment from #161 for background.

File test_data/sample_es7.json was introduced in that PR to handle the fact that _type in ES7 was removed (i.e. indices can no longer contain documents with multiple types). This isn't a big problem, but it would be cool if we could figure out how to eliminate this added complexity in the CI and remove that file, possibly by adding some argument to the ES7 mapping that says the default document type is line.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant