Eliminate a useless tap() call
#8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I eliminated the `tap()` call in this because the `Feature#on` method returns `self`, which is the instance of the `Feature` itself. Therefore, it would be the same as what the `tap()` call is doing. I suspect this was done maybe before the `on()` method returned `self`. Either way, now it seems useless to use a `tap()` call there.
|
👍 merge it |
drewdeponte
added a commit
that referenced
this pull request
Jul 31, 2015
…ture_registry Eliminate a useless `tap()` call
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I eliminated the
tap()call in this because theFeature#onmethodreturns
self, which is the instance of theFeatureitself.Therefore, it would be the same as what the
tap()call is doing. Isuspect this was done maybe before the
on()method returnedself.Either way, now it seems useless to use a
tap()call there.You can see the
on()definition returnselfat the following.https://github.com/codebreakdown/togls/blob/master/lib/togls/feature.rb#L16