Make fallback resort to next toggle driver #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why you made the change: I did this because previously when toggle reconstitution would fail due to a miss-match, or a missing value, etc. It would simply return a NullToggle. This short-circuited the process and resulted in the toggle evaluating to false. The problem was that it was not falling back to the other toggle drivers and eventually falling back to the defaults held by the in-memory drivers. I resolved this by modifying the toggle repository `get` method to check the success/failure of toggle reconstitution and fall back to the previous toggle drivers if reconstitution failed. This will make it so that if for any of the above possible reasons for failure, it will follow the natural driver fallback path rather than short-circuiting with a NullToggle.
| toggle_data = fetch_toggle_data(id) | ||
| return reconstitute_toggle(toggle_data) if toggle_data | ||
| Togls::ToggleMissingToggle.new | ||
| @drivers.reverse.each do |driver| |
There was a problem hiding this comment.
you could use reverse_each here if you want.
drewdeponte
deleted the
make_fallback_process_fallback_to_next_toggle_driver
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why you made the change:
I did this because previously when toggle reconstitution would fail due to a
miss-match, or a missing value, etc. It would simply return a NullToggle. This
short-circuited the process and resulted in the toggle evaluating to false. The
problem was that it was not falling back to the other toggle drivers and
eventually falling back to the defaults held by the in-memory drivers.
I resolved this by modifying the toggle repository
getmethod to check thesuccess/failure of toggle reconstitution and fall back to the previous toggle
drivers if reconstitution failed. This will make it so that if for any of the
above possible reasons for failure, it will follow the natural driver fallback
path rather than short-circuiting with a NullToggle.