Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Essentials v2 API #38

Closed
paladin0 opened this issue Mar 16, 2020 · 4 comments
Closed

Add support for Essentials v2 API #38

paladin0 opened this issue Mar 16, 2020 · 4 comments

Comments

@paladin0
Copy link

Is there a plan to expand this to the essentials/new essentials API?

@jarekwg
Copy link
Member

jarekwg commented Mar 16, 2020

Hi @paladin0,

Interesting. I've just had a quick read of the plan for essentials API. Looks like it's very compatible.

I believe all we'd need is a product flag to pass into the Myob constructor. For backwards compatibility, can default to accountright, but can be set to essentials. This will then dictate what base url is used.
The endpoints really do appear identical, which is pretty cool:
https://developer.myob.com/api/accountright/v2/contact/
https://developer.myob.com/api/accountright/essentials-new-v2/contact/
So I think we wouldn't need to bother with a separate endpoints file. Wherever there's missing feature parity, we'd leave it to MYOB's api to let the user know the endpoint is unavailable. If this turns out to be a bad idea, can always split them off in future.

So to answer your question, I think support for the new essentials can definitely be added to this package. Would you be interested in offering a PR to get us started?

Cheers,

@jarekwg jarekwg changed the title Is there a plan to expand this to the essentials/new essentials API? Add support for Essentials v2 API Mar 16, 2020
@paladin0
Copy link
Author

I think keeping them as the same is fine

however is this package already V2 compatible? as they have changed a few things
https://developer.myob.com/api/accountright/api-overview/v2-changes/

as i think there are more changes needed

@jarekwg
Copy link
Member

jarekwg commented Mar 16, 2020

Yep, this package only supports AccountRight Live API v2.

'x-myobapi-version': 'v2',

@jarekwg
Copy link
Member

jarekwg commented May 30, 2021

It appears the two have been merged entirely now. https://developer.myob.com/api/accountright/v2/
Probs safe to close this off.

@jarekwg jarekwg closed this as completed May 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants