Add repl lens #157
Add repl lens #157
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## test-matching #157 +/- ##
=================================================
+ Coverage 82.97% 83.21% +0.23%
=================================================
Files 17 17
Lines 423 429 +6
Branches 100 100
=================================================
+ Hits 351 357 +6
Misses 72 72
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
fdodino
force-pushed
the
fix-#150-repl-lens
branch
from
bdf4c68
to
43669d7
Compare
| "keybindings": [ | ||
| { | ||
| "command": "wollok.start.repl", | ||
| "key": "ctrl+r", | ||
| "mac": "cmd+r", | ||
| "when": "editorTextFocus && resourceExtname == .wlk" | ||
| }, | ||
| { | ||
| "command": "wollok.run.allTests", | ||
| "key": "ctrl+r", | ||
| "mac": "cmd+r", | ||
| "when": "editorTextFocus && resourceExtname == .wtest" | ||
| } |
| @@ -0,0 +1,12 @@ | |||
| // This file is linked from both client and server | |||
There was a problem hiding this comment.
Aca me parece que git no esta versionandolo como un hard link, a mi por ejemplo cuando me lo clono me lo toma como dos archivos distintos e independientes.
There was a problem hiding this comment.
sí, me parece que me pasó, es una pena, porque yo no quería complicarla mucho: si hay que poner un script en el pre-install y adaptarlo a windows o linux/mac es medio una paja. Por otra parte suele pasar que querés reutilizar constantes y sobre todo funciones en el cliente y el server, hay que buscar otro approach.
Co-authored-by: ivojawer <ivojawerbaum@gmail.com>
| @@ -0,0 +1,12 @@ | |||
| // This file is linked from both client and server | |||
| "keybindings": [ | ||
| { | ||
| "command": "wollok.start.repl", | ||
| "key": "ctrl+r", | ||
| "mac": "cmd+r", | ||
| "when": "editorTextFocus && resourceExtname == .wlk" | ||
| }, | ||
| { | ||
| "command": "wollok.run.allTests", | ||
| "key": "ctrl+r", | ||
| "mac": "cmd+r", | ||
| "when": "editorTextFocus && resourceExtname == .wtest" | ||
| } |
Qué trae
ln) del archivo de constantes (ahora shared definitions) para poder reutilizarlas entre cliente y servidorImportante
Hay que mergear este PR después del que armó Ivo
Screenshots