Test options exact match #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #141 +/- ##
==========================================
+ Coverage 84.05% 84.35% +0.30%
==========================================
Files 9 9
Lines 671 684 +13
Branches 154 162 +8
==========================================
+ Hits 564 577 +13
Misses 107 107 ☔ View full report in Codecov by Sentry. |
fdodino
approved these changes
Mar 23, 2024
|
@ivojawer , ahí lo probé en Windows, funciona de 10: con CMD
con Powershell
con Git Bash
|
|
También lo probé con el cambio que te sugerí y funciona ok. Solo encontré que hay un test que se rompe. |
Co-authored-by: Fernando Dodino <fernando.dodino@gmail.com>
|
Tremendo laburo dodain! Graciasss 😇 |
PalumboN
approved these changes
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relacionado a uqbar-project/wollok-lsp-ide#156 cambia como se usan las opciones file/describe/test para que en vez de convertirlo en un fqn recorra el AST para encontrar un test exacto
Usado por uqbar-project/wollok-lsp-ide#158