Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with joined-table inheritance #62

Closed
mush42 opened this issue Feb 6, 2019 · 3 comments
Closed

Compatibility with joined-table inheritance #62

mush42 opened this issue Feb 6, 2019 · 3 comments

Comments

@mush42
Copy link
Contributor

mush42 commented Feb 6, 2019

Currently sqlalchemy-mptt tries to set table indexes in the table_args class method. This make sqlalchemy complains when it tries to construct child classes because it couldn't find columns declared in the base class.
I fixed this in my local setup by adding index=True to column definition, instead of defining indexs in a separate class method.

Should I create a PR to fix this?

@uralbash
Copy link
Owner

uralbash commented Feb 6, 2019

@mush42 Yes sure it would be great if you add it

@snitkoff
Copy link

snitkoff commented Dec 5, 2019

@uralbash It would be great if you paid attention to this request #63

@uralbash
Copy link
Owner

@snitkoff @mush42 Sorry for the wait, I merge your changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants