Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remind button always shows if remindButtonTitle is set #45

Closed
JagCesar opened this issue Apr 19, 2016 · 2 comments
Closed

Remind button always shows if remindButtonTitle is set #45

JagCesar opened this issue Apr 19, 2016 · 2 comments

Comments

@JagCesar
Copy link
Contributor

Hey!

Let me start of by thanking you for writing this. Much love.

I ran across a bug and wanted to report it, not sure if I'm missing something. If it's a bug I'll gladly fix it and send a PR.

If daysBeforeReminding is set to zero and remindButtonTitle is set, the remind Button appears in the rate pop up. The bug seems to be in showsRemindButton()

showsRemindButton() should return false if daysBeforeReminding is set to zero.
@coneybeare
Copy link
Member

I agree, that looks like an oversight, considering we do a similar check here. I would entertain a pull request fixing it.

@JagCesar
Copy link
Contributor Author

Sweet. I'm on it.

@JagCesar JagCesar mentioned this issue Apr 22, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@coneybeare @JagCesar