Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NockStack guard page #150

Closed
ashelkovnykov opened this issue Dec 1, 2023 · 2 comments
Closed

NockStack guard page #150

ashelkovnykov opened this issue Dec 1, 2023 · 2 comments
Assignees
@ashelkovnykov

Comments

@ashelkovnykov
Copy link
Contributor

The NockStack should have a guard page for safety and so that we can detect OOM errors during computation. Currently, there's no defense against the two stacks in 2Stackz clobbering each other.
@eamsden
Copy link
Collaborator

eamsden commented Dec 9, 2023 •
edited
Loading

per discussion with @ashelkovnykov and I believe originally due to @joemfb: we are going to put a Nockstack OOM (bail:meme) check in the allocation routines. ( #172 ) The guard page will also be implemented but will simply attempt to recenter, and rethrow the SIGSEGV if it cannot. This will be a security and debugging measure only and should never occur in normal pier operation.

@ashelkovnykov
Copy link
Contributor Author

Resovled by #211 and #202

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ashelkovnykov ashelkovnykov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@eamsden @ashelkovnykov