jets: fix jet_rev #193
Merged
jets: fix jet_rev #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@drbeefsupreme this should actually call |
eamsden
requested changes
Dec 19, 2023
eamsden
approved these changes
Dec 20, 2023
ashelkovnykov
approved these changes
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jet_revhad an issue with the indirect atom case.IndirectAtom::new_rawwould normally be fine since we normalize, but since we're reversing endianness, we end up using the extra space. So the fix is to useIndirectAtom::new_raw_bytesinstead.I've also added a test case that catches this, which fails for the previous version.