Re-enable %mean hints in +mook and refactor SIGINT handling
#222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No idea why the linter is whining. Everything builds, tests, and lints fine on my end using |
|
@ashelkovnykov I just opened #223 so we can have in-sync rust versions between CI and devs without forcing Nix on people. |
|
Just a friendly reminder about this PR – merging the %mean hint changes will improve some of the error messages. @eamsden @tacryt-socryp Without the changes: With the changes: |
|
Thanks for the reminder, we will definitely get to this! |
|
The necessary part of this was restaged in #273. We're going to completely rethink aborts and bails in the near future, so this PR is obsolete. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
%meanhint processing in+mook. They were disabled around November of last year when they caused issues with booting pills.%meanhint processing in+mook(variable name shadowing issue - we were using the wrongcellvar)signal_hookcrate for processing SIGINTs with a flag that was checked on Nock2,9, and11. We nowmprotect()the entireNockStackmemory arena onSIGINTand gracefully recover from the resultingSIGSEGV.Resolves #144 & #152
Note: I don't think that the double-tap case of
SIGINTis being handled fully correctly right now, but it's difficult for me to check because of the machine from which I need to work on for now. Would appreciate whomever reviews this PR to play around with sendingSIGINTs viaCtrl + Cand compare to the ergonomics of doing so in Vere. Otherwise, I'll get to it on April 1, once I have my regular work machine back in action.