Skip to content
This repository has been archived by the owner on Aug 14, 2019. It is now read-only.

web talk error (talk-command mark parse error) #438

Closed
belisarius222 opened this issue Oct 11, 2017 · 3 comments
Closed

web talk error (talk-command mark parse error) #438

belisarius222 opened this issue Oct 11, 2017 · 3 comments

Comments

@belisarius222
Copy link
Contributor

I was unable to respond to ~palfun's comet's porch, so I thought I'd test sending a message to a planet. When I hit enter, my browser (chrome on ubuntu; my planet is running urbit 0.4.5) took me to a page with the following contents:

{"publish":[{"serial":"0v4.2ouge.6plna.7bu9v.84j0l.4i00a.0i8qb","audience":{"~pittyp-datfun":{"envelope":{"visible":true,"sender":null},"delivery":"pending"},"~rovnys-ricfer/porch":{"envelope":{"visible":true,"sender":null},"delivery":"pending"}},"statement":{"bouquet":[],"speech":{"lin":{"txt":"tse","say":true}},"date":1507748048050}}]}
ford: cast %talk-command
ford: casting %json to %talk-command
%need
/~rovnys-ricfer/home/0/mar/talk/command:<[16 9].[16 26]>
/~rovnys-ricfer/home/0/mar/talk/command:<[16 5].[123 5]>
/~rovnys-ricfer/home/0/mar/talk/command:<[15 17].[123 5]>
@Fang-
Copy link
Member

Fang- commented Oct 11, 2017

Hey, what a coincidence, I'm currently touching *~all of that code!~*

I'm confused as to why it's failing (to parse that data into a talk command). Relevant code is here, but a quick glance seems to indicate that your data fits those parsers just fine. Not to mention, this has worked for the past year(s?), so mystery all around.

That said, let's put this on hold, and see if it still exists after new talk goes live. I'm currently rewriting the marks anyway.

@Fang- Fang- changed the title web talk error web talk error (talk-command parse error) Oct 11, 2017
@Fang- Fang- changed the title web talk error (talk-command parse error) web talk error (talk-command mark parse error) Oct 11, 2017
@belisarius222
Copy link
Contributor Author

Ok. Thanks for looking into it.

@Fang- Fang- added the old talk label Oct 11, 2017
@Fang-
Copy link
Member

Fang- commented Dec 18, 2017

Sending DMs to comets seems to work fine. The above error still occurs when sending to an invalid audience. "~ship-name" doesn't automatically get converted to "~ship-name/inbox" though, so there's room for usability improvement there.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants