Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No integration with browser history #41

Closed
Fang- opened this issue Jan 10, 2019 · 5 comments
Closed

No integration with browser history #41

Fang- opened this issue Jan 10, 2019 · 5 comments

Comments

@Fang-
Copy link
Member

Fang- commented Jan 10, 2019

I get that this might be a pain to get in, depending on how things are set up, but here's an issue for it anyway:

Pressing back in the browser takes me out of Bridge, rather than to the previous screen. Pressing forward then does bring me back, but to some screen I visited sometime, not necessarily the one I was looking at when I hit back. This feels very painful.

@jtobin
Copy link
Contributor

jtobin commented Jan 11, 2019

This one is a big wontfix for the time being -- the app is really a SPA that just appears to have many pages. 😄

@jtobin jtobin closed this as completed Jan 11, 2019
@galenwp
Copy link

galenwp commented Jan 11, 2019

Not sure what router you're using — but manipulating browser history usually isn't too painful. It'd be nice to do this eventually.

@jtobin
Copy link
Contributor

jtobin commented Jan 11, 2019

We're using jtobin's custom in-house router extraordinaire. Route harder; route faster.™

(And yeah, perhaps browser history integration is not as much work as I naïvely thought it to be -- I don't really know much about this kind of thing.)

@galenwp
Copy link

galenwp commented Jan 11, 2019

Ha! Well in that case...

No need to hand roll it under pressure. Everything you're looking for is here: https://developer.mozilla.org/en-US/docs/Web/API/History_API

@Fang- Fang- reopened this Jan 11, 2019
@iamwillkim iamwillkim transferred this issue from another repository Feb 12, 2019
@iamwillkim
Copy link
Contributor

closing as issue is already in #7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants