Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle errors in constructors #48

Closed
jtobin opened this issue Jan 13, 2019 · 1 comment
Closed

Handle errors in constructors #48

jtobin opened this issue Jan 13, 2019 · 1 comment

Comments

@jtobin
Copy link
Contributor

jtobin commented Jan 13, 2019

A lot of Maybe values are examined a number of times, unnecessarily. It would usually suffice to examine stuff that we potentially could throw on, e.g. usually pointCursor, contracts, etc. in the constructor itself, rather than in the render method and elsewhere.

@iamwillkim iamwillkim transferred this issue from another repository Feb 12, 2019
@jtobin
Copy link
Contributor Author

jtobin commented Feb 26, 2019

Going to close this -- I think it's still likely to be smart practice, but is not the whole error-handling story, and is a bit too vague as-is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant