Skip to content
This repository has been archived by the owner on Dec 13, 2022. It is now read-only.

Migrate researched components to scries #43

Closed
10 tasks done
matildepark opened this issue Aug 3, 2020 · 2 comments
Closed
10 tasks done

Migrate researched components to scries #43

matildepark opened this issue Aug 3, 2020 · 2 comments
Assignees
Labels
priority: 2 Other tasks are contingent upon this task's completion. High leverage.

Comments

@matildepark
Copy link
Contributor

matildepark commented Aug 3, 2020

Talking with @Fang-:

  • Links and Chat already have on-peeks, but maybe not for stuff web interface wants; however, the logic for writing the subscription's initial logic as an on-peek is guaranteed to be in there already to migrate
  • Basically, anywhere we do an initial subscription can be a scry

When Chat opens and gets the first 20 messages from every room — that can be a scry. Clicking on a room and getting the backlog, also a scry.

Metadata can be a scry; loading contacts data for a group can be a scry; getting a Publish post can be a scry.

We would be eliminating "initial subscriptions" in favour of scrying; and then subscribing to updates after our initial scry.

The gains are small at first but would pay off going forward.

Back-end (@baudtack)

  • s3-store

  • metadata-store

  • group-store

  • graph-store

  • launch

  • Might have to double-check to define a mark to json conversions.

  • Change subscription paths to updates, instead of initial (src/logic/subscription/global.ts) and call scry instead of the initial subscription.

  • In the global.ts you could call scry instead of opening a subscription. You can find the scry function in src/logic/api/base.ts.

  • It assumes a certain path. We don't know if that correlates with on-peek yet, but you can see an example in the base-hash scry inside file-server.

Front-end (?)

  • s3-store
  • metadata-store
  • group-store
  • graph-store
  • launch
@matildepark matildepark added the priority: 2 Other tasks are contingent upon this task's completion. High leverage. label Aug 24, 2020
@matildepark
Copy link
Contributor Author

@baudtack currently on FE implementation of the scry interface; working with @liam-fitzgerald and @Fang- where needed.

@matildepark
Copy link
Contributor Author

PRing later today for front-end stuff

pinging Liam for review

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
priority: 2 Other tasks are contingent upon this task's completion. High leverage.
Projects
None yet
Development

No branches or pull requests

2 participants