Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github-suggested Rust workflow #31

Merged
merged 4 commits into from
Feb 28, 2023
Merged

Conversation

eamsden
Copy link
Collaborator

@eamsden eamsden commented Feb 24, 2023

This gets us basic "it builds and tests or no merge for you" CI courtesy GitHub suggesting a CI setup and @philipcmonk noticing the suggestion.

cc @lukestiles

@eamsden eamsden marked this pull request as ready for review February 24, 2023 22:55
Co-authored-by: Edward Amsden <edward@tlon.io>
Copy link
Contributor

@ashelkovnykov ashelkovnykov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tested on my own fork and it ran successfully in the PR as well. No tests yet, but the workflow is ready.

We will want to setup a branch protection rule for status that the "Ares" workflow is required to pass for GitHub to allow merging.

@eamsden on the topic of merging, I don't have permissions for this repo to merge.

@eamsden
Copy link
Collaborator Author

eamsden commented Feb 28, 2023

@ashelkovnykov you can now.

@zalberico can you add @ashelkovnykov to the urbit org and to the New Mars team?

@zalberico
Copy link

He was already in the urbit org, but is now added to the new mars team

@ashelkovnykov
Copy link
Contributor

Still unauthorized to approve merges:
unauthorized
I think the issue is that I only have "write" permissions for the repo in the New Mars team. I believe I need "maintainer" permissions.

@zalberico @eamsden @philipcmonk

@zalberico
Copy link

@ashelkovnykov made you a maintainer

@ashelkovnykov ashelkovnykov merged commit f4bbc25 into status Feb 28, 2023
@ashelkovnykov ashelkovnykov deleted the eamsden-configure-CI branch February 28, 2023 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants