-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Github-suggested Rust workflow #31
Conversation
Co-authored-by: Edward Amsden <edward@tlon.io>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Tested on my own fork and it ran successfully in the PR as well. No tests yet, but the workflow is ready.
We will want to setup a branch protection rule for status
that the "Ares" workflow is required to pass for GitHub to allow merging.
@eamsden on the topic of merging, I don't have permissions for this repo to merge.
@ashelkovnykov you can now. @zalberico can you add @ashelkovnykov to the urbit org and to the New Mars team? |
He was already in the urbit org, but is now added to the new mars team |
@ashelkovnykov made you a maintainer |
This gets us basic "it builds and tests or no merge for you" CI courtesy GitHub suggesting a CI setup and @philipcmonk noticing the suggestion.
cc @lukestiles