hoon: fix jet mismatch in +shas #5861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The C portion of this needs to make its way to the new urbit/vere repo. @joemfb , would you mind cherrypicking the relevant commits into a new PR on urbit/vere? |
This was referenced Mar 24, 2023
|
I ported the |
|
Should this retarget next/kelvin/412 @belisarius222 ? |
joemfb
changed the title
|
I've updated this PR to resolve the +shas jet mismatch in favor of the jet. /cc @frodwith |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes jet mismatch in +shas, introduced with urcrypt in v1.6.
+shasis used for %gall agent wires, and therefore ends up in %ames flows, so this mismatch has a dramatic and observable effect. It's the cause of the event log replay mug mismatches that effect piers booted before v1.6 and subsequently upgraded. #5304 and #5836 are representative examples. Thanks to @Fang- for tracking down an accessible reproduction, and @frodwith for helping to find the root cause.This PR cannot be released before #5701.