hoon: 138k #6615
Merged
hoon: 138k #6615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, this would replace the entire subject's type with the type of the wing. Now we use +take to descend into the subject and replace only the type of the affected wing. We also lightly refactor the implementation, to resemble +cool more closely. Co-authored-by: joemfb <joemfb@users.noreply.github.com>
And use hoon-style boolean syntax instead of numberic literals. Co-authored-by: joemfb <joemfb@users.noreply.github.com>
They were not handling the %over and %spec cases correctly. We update the %over cases to recurse as they should, and the %spec cases to +mint and +crop respectively. Co-authored-by: joemfb <joemfb@users.noreply.github.com>
Since this is the ?# codepath, we want to drop any faces that might already exist, since we'll bring our own (through %name in +gain:ar). Co-authored-by: joemfb <joemfb@users.noreply.github.com>
Co-authored-by: joemfb <joemfb@users.noreply.github.com>
Co-authored-by: joemfb <joemfb@users.noreply.github.com>
Co-authored-by: joemfb <joemfb@users.noreply.github.com>
The result is only guaranteed to be an atom if both parts of the cell are nouns. Otherwise, it could still be a specific kind of cell. Co-authored-by: joemfb <joemfb@users.noreply.github.com>
When we recur into a %cell or %over, we need to update the axis appropriately. Co-authored-by: joemfb <joemfb@users.noreply.github.com>
Co-authored-by: joemfb <joemfb@users.noreply.github.com>
Into the head and tail for more complete gains. Co-authored-by: joemfb <joemfb@users.noreply.github.com>
We are commonly looking for both the type and axis of a specific wing. +fend gives you both.
hoon: allow `%.` in spec mode
hoon: further explore ?#, fix bugs
hoon: add pin and awl arms to test and trim subaxes
Added regression tests as asked by @joemfb to test that currying and composition gates strip faces and that the subject of a gate returned by ++curr nests under the head of curried gate's subject.
hoon: fix gate currying
hoon: add +zip to jar engine
hoon: remove rut:by, duplicate of urn:by
hoon: refactor unnecessary parameter to bif:by
Merged
|
CI is failing since it's not using a compatible runtime (ie, one built from b3389ef backs out a change from #5884 -- I had suggested that a |
hoon: fix jet mismatch in +shas
Revert "hoon: add pin and awl arms to test and trim subaxes"
pkova
added a commit
to urbit/vere
that referenced
this pull request
Oct 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft PR to accumulate upcoming Hoon changes that will go into the next Hoon Kelvin, 138.