Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add integration with golangci-lint #1663

Closed
Tracked by #833
meatballhat opened this issue Jan 23, 2023 · 2 comments · Fixed by #1694 or #1697
Closed
Tracked by #833

Add integration with golangci-lint #1663

meatballhat opened this issue Jan 23, 2023 · 2 comments · Fixed by #1694 or #1697
Milestone
Release 3.x

Comments

@meatballhat
Copy link
Member

meatballhat commented Jan 23, 2023 •
edited
Loading

The golangci-lint meta-linting tool is widely used to ensure various classes of bugs and maintenance hindrances stay out of the code. Introducing this tool will almost certainly result in a lot of warnings and errors, so I'm happy to consider a gradual adoption via config file tweaking.
@meatballhat meatballhat mentioned this issue Jan 23, 2023
Open
21 tasks
@meatballhat meatballhat added this to the Release 3.x milestone Jan 23, 2023
This was referenced Mar 5, 2023
Merged
Merged
@skelouse skelouse reopened this Mar 7, 2023
@skelouse
Copy link
Contributor

skelouse commented Mar 8, 2023

Did some testing with golangci-lint: https://github.com/skelouse/cicd-test/blob/main/.github/workflows/golangci-lint.yml

@skelouse skelouse mentioned this issue Mar 8, 2023
Merged
@skelouse skelouse reopened this Dec 3, 2023
@skelouse skelouse mentioned this issue Dec 3, 2023
Merged
@bartekpacia
Copy link
Member

I think this can be closed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release 3.x
Development

Successfully merging a pull request may close this issue.

Fix linting issues skelouse/cli
v3 Add integration with golangci-lint skelouse/cli
4 participants
@meatballhat @dearchap @bartekpacia @skelouse