v1 bug: Wrong document in Flags.

[18kondo]

my urfave/cli version is

2.0.0

Checklist

• Are you running the latest v1 release? The list of releases is here.
• Did you check the manual for your release? The v1 manual is here
• Did you perform a search about this problem? Here's the Github guide about searching.

Dependency Management

• My project is using go modules.
• My project is using vendoring.
• My project is automatically downloading the latest version.
• I am unsure of what my dependency management setup is.

Describe the bug

Wrong document in flag.

To reproduce

https://github.com/urfave/cli/blob/master/docs/v1/manual.md#flags

package main

import (
  "fmt"
  "log"
  "os"

  "github.com/urfave/cli"
)

func main() {
  app := cli.NewApp()

  app.Flags = []cli.Flag {
    cli.StringFlag{
      Name: "lang",
      Value: "english",
      Usage: "language for the greeting",
    },
  }
}

go build error.

go build
=> cannot use cli.BoolFlag literal (type cli.BoolFlag) as type cli.Flag in array or slice literal:
        cli.BoolFlag does not implement cli.Flag (Apply method has pointer receiver)

Expected behavior

If you add &, the build was successful.

cli.StringFlag{
↓
&cli.StringFlag{

You should cure the document or revert the v1 changes.

Run go version and paste its output here

go version go1.13 darwin/amd64

Run go env and paste its output here

GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/username/Library/Caches/go-build"
GOENV="/Users/username/Library/Application Support/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GONOPROXY=""
GONOSUMDB=""
GOOS="darwin"
GOPATH="/Users/username/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/Users/k-kondo/go/go1.13"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/Users/username/go/go1.13/pkg/tool/darwin_amd64"
GCCGO="gccgo"
AR="ar"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/8m/dtc235s11sv585p1wvk068vn2jq9h8/T/go-build161388641=/tmp/go-build -gno-record-gcc-switches -fno-common"

[asahasrabuddhe]

There seems to be some confusion here. Your code indicates the use of v1 but the error and the suggested fix indicates the use of v2.

If you want to use v2, please import github.com/urfave/cli/v2 and refer to the v2 manual here.

Could you please share your go.mod file? It would help me help you better.

[18kondo]

Thank you for your answer.
I have used v1 so far, but when I updated, an error occurred, so I will use v2 in the future.

I'm sorry. I don't use go mod and can't share.