Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hero Banner (Media Blend variant) as EDS block #87

Closed
pahupe opened this issue Jan 31, 2024 · 4 comments
Closed

Hero Banner (Media Blend variant) as EDS block #87

pahupe opened this issue Jan 31, 2024 · 4 comments
Assignees
Labels
Milestone

Comments

@pahupe
Copy link
Contributor

pahupe commented Jan 31, 2024

Goals:

  • Implement the Media Blend Hero Banner variant as an Adobe AEM EDS block
  • Use this implementation as an example (for SAP) wrt/ AEM EDS best practices

Constraints:

  • For this scope of this ticket, omit the subcomponents for which we don't have metadata / content, such as:
    ** stars/ratings
    ** avatar
    ** CTAs/buttons
  • Media element:
    ** Implement a version with a background image (instead of a video) first. Reason: All existing hero banner content has an image, not a video (ref: https://main--hlx-test--urfuwo.hlx.page/blog/2023/12/being-human-in-the-age-of-ai)
    ** Optional (can be split into separate ticket): Implement a video media element, as shown in the designs. Make use of the video wrapper implemented by @benpeter

References:

@sdmcraft
Copy link
Contributor

"Hero - Media blend" variant has to be used.
Copying related conversation

@karlpauls
Copy link
Collaborator

karlpauls commented Feb 15, 2024

@sdmcraft, as discussed, I merged the web component support via #133 but not as fix (to keep this issue open). Handing it back to you. If you prefer to have that be the resolution of this ticket and work with follow-up tickets that is fine by me - just wanted you to have the option.

@benpeter
Copy link
Collaborator

can this be closed? assuming the spillover is in #135 @sdmcraft ?

@benpeter benpeter added this to the Mid-March presentation milestone Feb 20, 2024
@benpeter benpeter removed the mvp label Feb 20, 2024
@sdmcraft
Copy link
Contributor

Closing this. Spillover work tracked in #135
/cc @karlpauls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done 👏🏻
Development

No branches or pull requests

5 participants