Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

checking file existence #18

Closed
keunwoochoi opened this issue Dec 24, 2015 · 1 comment
Closed

checking file existence #18

keunwoochoi opened this issue Dec 24, 2015 · 1 comment

Comments

@keunwoochoi
Copy link
Contributor

As I once mentioned in the comments of #15, run() process doesn't check if the file really exists in the path. When there's no file, msaf.process() doesn't show any error but returns a blank array.
Wouldn't it be better if it check if the file/folder exists? I'd PR if you think so.
@urinieto
Copy link
Owner

I agree. A PR be highly welcomed, thanks!

@keunwoochoi keunwoochoi mentioned this issue Dec 27, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@urinieto @keunwoochoi