fix(graphcache): fix loop bug when schema is present #2831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoviDeCroock
force-pushed
the
reproduce-loop-bug
branch
from
1bc176f
to
5a67e76
Compare
|
Thank you for this! Big fix for us. |
kitten
approved these changes
Dec 1, 2022
There was a problem hiding this comment.
Just gave this another look over; re. simplifying some of the conditions we have across this file, I think it's fine currently, and I don't see anything we could batch with this change.
For context, originally the theory was that cacheMissOps$'s filter needed a change, however, network-only doesn't even arrive there due to the differentiation via nonCacheOps$.
Merged
3 tasks
This was referenced Mar 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #2830
Summary
When we have a partial result we should stop the query from re-fetching, this was a case that we hadn't caught yet. The issue here being that we will also eat the error as we aren't caching those. Basically the query will complete and we will get two results from cache without the errors rather than the plain result with an error added on top.