Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Longer green for vehicle phase #319

Merged

Conversation

paulbourelly999
Copy link
Contributor

@paulbourelly999 paulbourelly999 commented Feb 16, 2024

PR Details

Description

Update EVC Config to have longer greens for vehicle phase.
For context, this file adds 35sec of green on signal group 2, 6 (the carma's starting usual lane) I believe and only 5 sec for the other lanes.

Related Issue

Motivation and Context

Reduce scenario execution time spent waiting on greens

How Has This Been Tested?

CDASim

Types of changes

  • Defect fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that cause existing functionality to change)

Checklist:

  • I have added any new packages to the sonar-scanner.properties file
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
    CARMA Contributing Guide
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@MishkaMN
Copy link
Contributor

Could you also add the docker volume back on the carma-config under this line. We used to have it, but it's somehow gone. I realized it yesterday
https://github.com/usdot-fhwa-stol/carma-config/blob/develop/ail_vru_uc1_scenario/docker-compose.yml#L385

@MishkaMN
Copy link
Contributor

For context, this file adds 35sec of green on signal group 2, 6 (the carma's starting usual lane) I believe and only 5 sec for the other lanes.

@paulbourelly999 paulbourelly999 marked this pull request as ready for review February 16, 2024 19:14
@paulbourelly999
Copy link
Contributor Author

paulbourelly999 commented Feb 16, 2024

Could you also add the docker volume back on the carma-config under this line. We used to have it, but it's somehow gone. I realized it yesterday https://github.com/usdot-fhwa-stol/carma-config/blob/develop/ail_vru_uc1_scenario/docker-compose.yml#L385

The volume is still there for me (

- ./evc_sumo/:/home/carma/src/resources/
)

@paulbourelly999 paulbourelly999 merged commit b76defb into release/lavida Feb 16, 2024
@paulbourelly999 paulbourelly999 deleted the cdar-802-update-evc-config-longer-greens branch February 16, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants