needimport supports extra options and links #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* extra options and links are imported * pre/post/template can be defined by needimport * same for style and layout Fixes #227
danieleades
reviewed
Apr 18, 2021
| link_list = re.split(";|,", links_string) | ||
| else: | ||
| link_list = links_string | ||
| for link in link_list: |
There was a problem hiding this comment.
do you want to add a type annotation to this function?
def _read_in_links(links_string: Union[str, List[str]]):
...?
There was a problem hiding this comment.
Yes, will add it.
Sorry I'm not so familiar with type annotations (till now) :)
danieleades
reviewed
Apr 18, 2021
Comment on lines
122
to
128
| # template_location = os.path.join(os.path.dirname(os.path.abspath(__file__)), "needimport_template.rst") | ||
| # with open(template_location, "r") as template_file: | ||
| # template_content = template_file.read() | ||
| # template = Template(template_content) | ||
| # content = template.render(needs_list=needs_list, hide=hide, id_prefix=id_prefix) | ||
| # self.state_machine.insert_input(content.split('\n'), | ||
| # self.state_machine.document.attributes['source']) |
There was a problem hiding this comment.
if this is no longer used, should it just be deleted?
There was a problem hiding this comment.
Ohh yes.
Will add you next time as reviewer.
Thanks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #227