-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
needimport ignores all links between needs #227
Comments
Hint: I could reproduce this with version |
Thanks for sharing this bug report. I can reproduce the bug for extra_links. Only for additional links (configured via needs_extra_links) I get this problem. They are not exported to So I see two bugs here, both related to
|
I can confirm that everything is working fine for regular In my case, the needs_extra_links:
|
* extra options and links are imported * pre/post/template can be defined by needimport * same for style and layout Fixes #227
* needimport supports extra options and links * extra options and links are imported * pre/post/template can be defined by needimport * same for style and layout Fixes #227 * Updated dep MarkupSafe to use newest version * Cleanup and type annotation for needimport
Thanks for fixing! I wanted to test this by locally installing sphinxcontrib-needs, but I failed because setup.py was apparently deprecated: so the following install steps from the README don't work anymore: @danwos : could you please provide the updated install steps? |
@arnoox The new instructions to build from sources are here https://github.com/useblocks/sphinxcontrib-needs/blob/master/docs/contributing.rst I guess the Readme update was missed during the Poetry migration. @danwos Do you want to point to |
Thanks for the hint 👍 and I have updated the docs. |
I have a proper
needs.json
containing some valid needs that are linked to each other. Now when I "needimport" this file, all needs are imported, but without links. I couldn't find a hint in the documentation, that specifies this behavior: https://sphinxcontrib-needs.readthedocs.io/en/latest/directives/needimport.htmlProbably this is a bug? Or are there any other way to achieve this?
The text was updated successfully, but these errors were encountered: