Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Store commands result in panic error with no value on stack #10

Closed
usefulmove opened this issue Jul 4, 2022 · 1 comment
Closed

Store commands result in panic error with no value on stack #10

usefulmove opened this issue Jul 4, 2022 · 1 comment
Labels
bug Something isn't working enhancement New feature or request error handling Handle errors gracefully feature request Improve and enhance user experience good first issue Good for newcomers

Comments

@usefulmove
Copy link
Owner

The store commands (sa, .a, sb, ...) cause panic errors when the stack is empty. The panic description does not sufficiently describe the cause of the error to the end user.

% comp sa
thread 'main' panicked at 'called `Option::unwrap()` on a `None` value', src/comp.rs:300:35
@usefulmove usefulmove added bug Something isn't working enhancement New feature or request good first issue Good for newcomers error handling Handle errors gracefully feature request Improve and enhance user experience labels Jul 4, 2022
@usefulmove
Copy link
Owner Author

Implemented with 0.20.4 on the development branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working enhancement New feature or request error handling Handle errors gracefully feature request Improve and enhance user experience good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@usefulmove