Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update compose-go spec to v1.20.0 with lagoon fixes #253

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

shreddedbacon
Copy link
Member

@shreddedbacon shreddedbacon commented Nov 3, 2023

This updates the compose-go library to 1.20.0 with the additional fixes required for lagoon.

Unfortunately though, this resulted in additional cases where things people may have done in previous versions of docker compose worked, do not work anymore.

Example, previously people may have defined <<: *default-volumes and <<: *default-user like so, but under the latest compose-go spec, this is not supported.

  php:
    build:
      context: .
      dockerfile: .docker/Dockerfile.php
      args:
        CLI_IMAGE: *project
    <<: *default-volumes
    <<: *default-user
    environment:
      <<: *default-environment
    depends_on:
      - cli
    labels:
      lagoon.type: nginx-php-persistent
      lagoon.name: nginx-php
      lagoon.persistent: /app/docroot/sites/default/files/

closes #252

@shreddedbacon
Copy link
Member Author

Leaving as draft until we make a call on when to fail builds for invalid docker-compose files or drop our fork

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Validation false positive for nested interpolation in docker-compose
1 participant