Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: lagoon.yml container-registry variable override checks #310

Merged
merged 1 commit into from
May 17, 2024

Conversation

shreddedbacon
Copy link
Member

@shreddedbacon shreddedbacon commented Apr 29, 2024

Just a quick refactor on the existing variables to allow them to be used without having to define username or password in the .lagoon.yml at all.

Validation gist

@shreddedbacon shreddedbacon added this to the 2.19.0 milestone Apr 29, 2024
@shreddedbacon shreddedbacon marked this pull request as ready for review April 30, 2024 04:38
@shreddedbacon shreddedbacon force-pushed the refactor-container-registry branch 2 times, most recently from 815b10d to 2907fd1 Compare May 16, 2024 06:06
…o define associated username or password fields in .lagoon.yml
Copy link
Member

@tobybellwood tobybellwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested offline, working

@shreddedbacon shreddedbacon merged commit 40815e6 into main May 17, 2024
2 checks passed
@shreddedbacon shreddedbacon deleted the refactor-container-registry branch May 17, 2024 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants