Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix directory permissions to create smaller opensearch-2 image #734

Merged
merged 3 commits into from
Jun 7, 2023

Conversation

tobybellwood
Copy link
Member

@tobybellwood tobybellwood commented Apr 23, 2023

The current opensearch-2 image is unnecessarily large - this PR uses a new fix-dir-permissions command in commons to allow only directories to be permission fixed, reducing the layer size for impacted directories.

In addition, there are a couple of tweaks to the opensearch-2 image to optimise caching - removing the sole dependency on hostname to allow the removal of yum.

@tobybellwood tobybellwood changed the title use multistage build for opensearch-2 Fix directory permissions to create smaller opensearch-2 image Jun 6, 2023
@tobybellwood tobybellwood requested a review from smlx June 7, 2023 00:28
Copy link
Member

@smlx smlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is a little bit confusing as there are a couple of different things going on in this PR (removing the hostname dependency, adding the fix-dir-permissions script). Maybe this should be split out into separate PRs?

images/opensearch/2.Dockerfile Show resolved Hide resolved
Copy link
Member

@smlx smlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tobybellwood tobybellwood merged commit 823d5dd into main Jun 7, 2023
1 check passed
@tobybellwood tobybellwood deleted the smaller_opensearch branch June 7, 2023 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants