Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Include Python 3.8 images #1887

Closed
wants to merge 1 commit into from

Conversation

fubarhouse
Copy link
Contributor

Checklist

  • Affected Issues have been mentioned in the Closing issues section
  • Documentation has been written/updated
  • PR title is ready for changelog and subsystem label(s) applied

Changelog Entry

Add images for use of Python 3.8

Closing issues

TBC

@fubarhouse fubarhouse changed the title Include Python 3.8 images [WIP] Include Python 3.8 images May 14, 2020
@tobybellwood
Copy link
Member

tobybellwood commented May 14, 2020

Ugh - this has just gave me a flashback - as soon as Alpine shifted their Python3 package from 3.7 to 3.8, we've inadvertently also installed 3.8 alongside in our 3.7 images...

(because we use python dockerhub images, but then have to use apk to add python3-dev packages
https://github.com/amazeeio/lagoon/blob/master/images/python/Dockerfile#L37-L38)

We'll have to rethink our use of apk here (I foreshadowed this in #1531 (comment))

Or only support a single version of Python3

python:/$ apk info | grep python3
python3
python3-dev
python:/$ which python
/usr/local/bin/python
python:/$ find / -name python
/usr/local/bin/python
python:/$ /usr/local/bin/python -V
Python 3.7.7
python:/$ find / -name python3
/usr/bin/python3
/usr/local/bin/python3
python:/$ /usr/local/bin/python3 -V
Python 3.7.7
python:/$ /usr/bin/python3 -V
Python 3.8.2

@fubarhouse
Copy link
Contributor Author

In regards to #1531 (comment), my vote would go to supporting one version via the system package manager...

Package management is tricky but if you are managing system packages along-side language specific package managers, maintenance is a lot better when using the system package manager....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants