Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build Python3.7 images from Alpine 3.10 instead of 3.11 #1889

Merged
merged 1 commit into from May 28, 2020

Conversation

tobybellwood
Copy link
Member

This PR forces Lagoon to use Alpine 3.10 to build Python 3.7 images instead of 3.11

This is because Alpine 3.11 defaults to Python 3.8, and as such will install the 3.8 version of Python3-dev (and Python3.8 as well to match the dependency), resulting in version duality. First discovered in testing #1887

For a later PR should be a rework of the Python images - there is a lot of optimisation that can be done - we may not need to augment the upstream images, or may be better using a glibc-based base image (e.g. buster-slim)

Checklist

  • Affected Issues have been mentioned in the Closing issues section
  • Documentation has been written/updated
  • PR title is ready for changelog and subsystem label(s) applied

Closing issues

Put closes #XXXX in your comment to auto-close the issue that your PR fixes (if such).

@tobybellwood tobybellwood added the 6-images-testing Base Images & Testing subsystem label May 15, 2020
@tobybellwood tobybellwood added this to the v1.6.0 milestone May 28, 2020
@Schnitzel Schnitzel merged commit bb35cf5 into master May 28, 2020
@tobybellwood tobybellwood deleted the hotfix/python37 branch July 2, 2020 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6-images-testing Base Images & Testing subsystem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants