Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add middleware to UI for security headers. #2381

Merged
merged 2 commits into from
Feb 3, 2022
Merged

Add middleware to UI for security headers. #2381

merged 2 commits into from
Feb 3, 2022

Conversation

steveworley
Copy link
Contributor

Description

LagoonUI doesn't currently respond with standard security response headers. This is a small PR to add a Middleware to express to add X-Frame-Options and X-Conetnt-Type-Options to all responses.

http -h http://localhost:3003
X-Content-Type-Options: nosniff
X-Frame-Options: SameOrigin
X-Powered-By: Express

rocketeerbkw
rocketeerbkw approved these changes Dec 8, 2020
View reviewed changes
Copy link
Member

@rocketeerbkw rocketeerbkw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@rocketeerbkw rocketeerbkw added this to the v2.1.0 milestone Dec 23, 2020
@tobybellwood tobybellwood modified the milestones: v2.1.0, v2.x Oct 14, 2021
@tobybellwood tobybellwood merged commit 200d8a8 into uselagoon:main Feb 3, 2022
@tobybellwood tobybellwood changed the title Add middleware for security headers. Add middleware to UI for security headers. Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rocketeerbkw rocketeerbkw rocketeerbkw approved these changes

Assignees
No one assigned
Labels
9-security Security subsystem
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@steveworley @rocketeerbkw @tobybellwood