Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom Backup and Restore Location Support #2820

Merged
merged 19 commits into from
Sep 30, 2021
Merged

Custom Backup and Restore Location Support #2820

merged 19 commits into from
Sep 30, 2021

Conversation

cdchris12
Copy link
Contributor

@cdchris12 cdchris12 commented Aug 27, 2021 •
edited
Loading

Checklist

  • Affected Issues have been mentioned in the Closing issues section
  • Documentation has been written/updated
  • PR title is ready for changelog and subsystem label(s) applied

This PR introduces the logic necessary to support custom, user-defined backup and restore locations for Lagoon's Backup As A Service.

Closing issues

Closes #2680

@cdchris12 cdchris12 added 1-api-auth API & Authentication subsystem 2-build-deploy Build & Deploy subsystem labels Aug 27, 2021
@cdchris12 cdchris12 self-assigned this Aug 27, 2021
@cdchris12 cdchris12 marked this pull request as ready for review September 1, 2021 23:46
rocketeerbkw
rocketeerbkw requested changes Sep 7, 2021
View reviewed changes
Copy link
Member

@rocketeerbkw rocketeerbkw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it confusing that we would have two environment variables for the backup bucket name LAGOON_BAAS_BUCKET_NAME and LAGOON_BAAS_CUSTOM_BACKUP_BUCKET?

services/keycloak-db/Dockerfile Outdated Show resolved Hide resolved
services/api/src/resources/backup/resolvers.ts Outdated Show resolved Hide resolved
services/api/src/resources/backup/resolvers.ts Outdated Show resolved Hide resolved
services/api/src/resources/backup/resolvers.ts Show resolved Hide resolved
@tobybellwood tobybellwood merged commit b74abe8 into main Sep 30, 2021
@tobybellwood tobybellwood deleted the custom_backup_restore_location_support branch September 30, 2021 22:25
@shreddedbacon shreddedbacon mentioned this pull request Nov 4, 2021
Merged
3 tasks
@cdchris12 cdchris12 mentioned this pull request Jul 6, 2022
Closed
@shreddedbacon shreddedbacon mentioned this pull request Jul 6, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rocketeerbkw rocketeerbkw rocketeerbkw approved these changes

@AlannaBurke AlannaBurke AlannaBurke left review comments

@bomoko bomoko Awaiting requested review from bomoko

Assignees

@cdchris12 cdchris12

Labels
1-api-auth API & Authentication subsystem 2-build-deploy Build & Deploy subsystem
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow project-level BaaS bucket & credentials
5 participants
@cdchris12 @rocketeerbkw @AlannaBurke @tobybellwood @Schnitzel