Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use a sql query to get project vars for restores rather than graphql #2910

Merged
merged 1 commit into from
Nov 4, 2021

Conversation

shreddedbacon
Copy link
Member

Checklist

  • Affected Issues have been mentioned in the Closing issues section
  • Documentation has been written/updated
  • PR title is ready for changelog and subsystem label(s) applied

#2820 added envvar support for restores, but uses a graphql query to return the project environment variables. This means that if a user with developer role tries to view the backups page with downloadable backups, they get a permission error.

Since these variables aren't exposed to the user, this PR changes it to use a sql query to get projects variables instead, and still allows developers to download production environment backups like they were able to previously.

@shreddedbacon shreddedbacon added the 1-api-auth API & Authentication subsystem label Nov 4, 2021
@tobybellwood tobybellwood merged commit a387742 into main Nov 4, 2021
@tobybellwood tobybellwood deleted the baas-restorelocation branch November 4, 2021 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1-api-auth API & Authentication subsystem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants