Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: throw an error on deployment errors triggered via the api #3568

Merged
merged 1 commit into from
Jun 19, 2024
Merged

fix: throw an error on deployment errors triggered via the api #3568

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 5 additions & 5 deletions services/api/src/resources/deployment/resolvers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -741,7 +741,7 @@ export const deployEnvironmentLatest: ResolverFn = async (
break;

default:
return `Error: Unknown deploy type ${environment.deployType}`;
throw new Error(`Error: Unknown deploy type ${environment.deployType}`);
}

userActivityLogger(`User triggered a deployment on '${deployData.projectName}' for '${environment.name}'`, {
Expand Down Expand Up @@ -790,7 +790,7 @@ export const deployEnvironmentLatest: ResolverFn = async (
meta,
`*[${deployData.projectName}]* Error deploying \`${environment.name}\`: ${error.message}`
);
return `Error: ${error.message}`;
throw new Error(error.message);
}
}
};
Expand Down Expand Up @@ -889,7 +889,7 @@ export const deployEnvironmentBranch: ResolverFn = async (
meta,
`*[${deployData.projectName}]* Error deploying \`${deployData.branchName}\`: ${error}`
);
return `Error: ${error}`;
throw new Error(error.message);
}
}
};
Expand Down Expand Up @@ -999,7 +999,7 @@ export const deployEnvironmentPullrequest: ResolverFn = async (
meta,
`*[${deployData.projectName}]* Error deploying \`${deployData.branchName}\`: ${error.message}`
);
return `Error: ${error.message}`;
throw new Error(error.message);
}
}
};
Expand Down Expand Up @@ -1121,7 +1121,7 @@ export const deployEnvironmentPromote: ResolverFn = async (
meta,
`*[${deployData.projectName}]* Error deploying \`${deployData.branchName}\`: ${error.message}`
);
return `Error: ${error.message}`;
throw new Error(error.message);
}
}
};
Expand Down