Support for Environment and Project IDs #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…etorcreate to ensure labels are always up to date
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main reason for this PR is to be able to provide Lagoon with the environment and/or project IDs so that the correct environment is updated in Lagoon. This is mainly because of environment names being made DNS compliant in Kubernetes, and Lagoon not being able to correctly find what it needs to update the environments correctly.
eg:
feature/env-1gets converted tofeature-env-1when provided to the controller, and on completion this is sent back to Lagoon, but Lagoon is expecting to seefeature/env-1. Instead now it will prefer the environment ID.Namespaces now will also get labelled with these IDs, and namespace patching is done on every deploy now. This is to ensure namespace labels are always up to date, and this allows us to update labels or add new labels in the future.
This can be merged and released prior to the core Lagoon fix being implemented.