Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: image url extraction #453

Merged
merged 3 commits into from Nov 12, 2022
Merged

fix: image url extraction #453

merged 3 commits into from Nov 12, 2022

Conversation

Zeng1998
Copy link
Contributor

No description provided.

@Zeng1998 Zeng1998 linked an issue Nov 12, 2022 that may be closed by this pull request
[bug] 发现一个 markdown 图片相关的小 Bug #452
Closed
@Zeng1998
Copy link
Contributor Author

  • change to the global mode. /\((.*?)\)/g
  • get the last match one. slice(-1)[0]
  • remove the parentheses. slice(-1,1)

@boojack boojack changed the title fix: image-url-extraction fix: image url extraction Nov 12, 2022
@boojack boojack merged commit 8cc0977 into main Nov 12, 2022
@eallion
Copy link
Contributor

eallion commented Nov 12, 2022

nice job!

@Zeng1998 Zeng1998 deleted the fix/image_url_extraction branch November 13, 2022 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boojack boojack boojack approved these changes

@lqwakeup lqwakeup Awaiting requested review from lqwakeup

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[bug] 发现一个 markdown 图片相关的小 Bug
3 participants
@Zeng1998 @eallion @boojack